Add to_dict and from_dict methods to Labware#113
Merged
michaelosthege merged 2 commits intomasterfrom Mar 31, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 95.74% 95.85% +0.10%
==========================================
Files 19 19
Lines 1198 1229 +31
==========================================
+ Hits 1147 1178 +31
Misses 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2878fc3 to
5b1e170
Compare
5b1e170 to
00aa3a7
Compare
Tobias-J
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Labware.from_dictalso work for recreatingTroughlabware based on the data.Implementation details
Troughtypes have different__init__parameters (rowsvs.virtual_rows) just like derived types can have different init parameters or attributes.I implemented
_from_dict_init_kwargsand_from_dict_attributeswhich can be overriden by derived types to account for customization.Some (hopefully) clever logic was necessary to support
buffers_trough = Labware.from_dict(data)returningTroughobjects even if that does not give a definite type hint.