Skip to content

Comments

Add CODEOWNERS for branch protection#12

Merged
TaprootFreak merged 3 commits intodevelopfrom
feature/add-codeowners
Jan 9, 2026
Merged

Add CODEOWNERS for branch protection#12
TaprootFreak merged 3 commits intodevelopfrom
feature/add-codeowners

Conversation

@TaprootFreak
Copy link

Summary

  • Add CODEOWNERS file requiring approval from @Danswar or @TaprootFreak for all changes
  • This enables the branch protection rule for main branch

Context

Branch protection rule has been configured on main with:

  • Required approving reviews: 1
  • Require review from Code Owners: enabled
  • Dismiss stale reviews: enabled
  • Force pushes: disabled
  • Branch deletions: disabled

Danswar and others added 3 commits November 25, 2025 11:55
Release: Default position endpoint & contract v1.0.6
Require approval from @Danswar or @TaprootFreak for all PRs to protected branches.
@TaprootFreak TaprootFreak changed the base branch from main to develop January 9, 2026 18:47
@TaprootFreak TaprootFreak merged commit 9d13f59 into develop Jan 9, 2026
TaprootFreak added a commit that referenced this pull request Jan 26, 2026
* fix: add principal to default position API response (#11)

* Add CODEOWNERS file for branch protection (#12)

Require approval from @Danswar or @TaprootFreak for all PRs to protected branches.

Co-authored-by: Danswar <48102227+Danswar@users.noreply.github.com>

* fix: use real Coingecko prices for testnet tokens (#14)

* fix: use real Coingecko prices for testnet tokens

- Add TESTNET_COINGECKO_MAPPING to map token symbols to Coingecko IDs
- WCBTC now fetches real Bitcoin price (~$100k) instead of fake $1
- Fixes incorrect collateralization display (was 0.01%, now ~200%)
- Fallback to $1 for stablecoins and unknown tokens

* fix: add null safety and improve error logging

* fix: return only USD from Coingecko, let updatePrices() calculate JUSD price

The 'eur' field is actually the price in JUSD (protocol stablecoin), not Euro.
By only returning USD, the correct JUSD price calculation in updatePrices()
is triggered: eur = usd / protocolStablecoinPrice

* chore: remove unused randRef variable

* Remove EUR/JUSD pricing complexity - use USD only

Since 1 JUSD = 1 USD (dollar stablecoin), there's no need for
currency conversion. This simplifies the pricing system:

- Remove /prices/eur endpoint from controller
- Remove getEuroPrice(), fetchEuroPrice() from service
- Remove euroPrice state variable
- Simplify PriceQueryCurrencies to just { usd?, btc? }
- Remove jusd calculations from ecosystem collateral stats

The API now works exclusively with USD, which is equivalent
to JUSD at 1:1 ratio.

* chore: use bitcoin ID for WBTC, remove dead code

* ci: add PR checks workflow for build and lint

* chore: rebrand d-EURO to JuiceDollar in telegram messages

* chore: update LICENSE copyright

* perf: skip Coingecko for JUSD - stablecoin is always $1

* fix: handle missing Coingecko price data gracefully

- Add explicit check for undefined price data on mainnet
- Use price?.usd checks instead of price === null
- Log warning when no price data available
- Prevents NaN calculations from undefined prices

* fix: prevent TypeError when poolSharesPrice is null

* Add dual container app deployment support (#15)

Deploy to both jdta and jdma container apps in DEV and PRD workflows.

* feat: mainnet support

* Version 1.1.0 (#16)

---------

Co-authored-by: Jonathan <59397732+jonathanchw@users.noreply.github.com>
Co-authored-by: Danswar <48102227+Danswar@users.noreply.github.com>
Co-authored-by: bernd2022 <104787072+bernd2022@users.noreply.github.com>
Co-authored-by: David May <david.leo.may@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants