Route CoinGecko via the in-cluster pricing proxy#53
Merged
Conversation
The api was always going to pro-api.coingecko.com directly with a query-string-keyed Pro key. That works on its own but cache-poisons any HTTP-cache that keys on the URL, and it bypasses the central pricing proxy that already holds the upstream key, runs a 60 s shared cache, and validates upstream error envelopes. - COINGECKO_BASE_URL is now the preferred env var: when set, requests go to that origin (typically the pricing proxy) and no auth header is added — the proxy injects the key. - COINGECKO_API_KEY remains supported as a direct fallback. Calls now route to pro-api.coingecko.com via header (`x-cg-pro-api-key`) instead of the cache-unfriendly `x_cg_pro_api_key` query string. - Bootstrap now requires at least one of the two so the service does not silently come up unauthenticated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolution priority
Test plan