Skip to content

Version 1.0 "Gustav"#1

Merged
TureBentzin merged 123 commits intomainfrom
development
Dec 28, 2022
Merged

Version 1.0 "Gustav"#1
TureBentzin merged 123 commits intomainfrom
development

Conversation

@TureBentzin
Copy link
Copy Markdown
Member

After now a bit more than 22 days of intense coding the first version of the core is ready.
Further Information on how the core works will be provided in the Wiki Section of this repository.
If you want to use this certain version you may want to compile it from git or use the following dependency

<dependency>
  <groupId>net.juligames.core</groupId>
  <artifactId>API</artifactId>
  <version>1.0-RELEASE-CANDIDATE-SNAPSHOT</version>
</dependency>

Copy link
Copy Markdown
Contributor

@Bommels05 Bommels05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the conversations again. I answered some things there.

Okey this file is now really not needed but 10K lines...
Copy link
Copy Markdown
Member Author

@TureBentzin TureBentzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is time to merge #1

Comment thread File Outdated
@@ -0,0 +1,75 @@
This File contains exactly 75 lines...
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good file

@TureBentzin TureBentzin linked an issue Dec 28, 2022 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@Bommels05 Bommels05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do it

Comment thread File
Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@Bommels05 Bommels05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow as I said in my original review you really made some great work here. I think all critical bugs are fixed now and even if you have just simply ignored some of my suggestions I really thank you that you did what I wanted at the end. I hope that this marks a important day in Juligames history and brings our server to a new level of quality. And to you, you should really take some time and relax a bit because you deserve it. Maybe a part of this time can also be spend in the USW Project next week but anyways what review from me would that be if I don´t include some cursed formatting. **_

  • - >

    [He**### re we** go!](``)

_**

@TureBentzin TureBentzin removed the request for review from Juliwilliamus December 28, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing PlainText resolving in core

3 participants