Version 1.4#23
Merged
TureBentzin merged 45 commits intomainfrom Feb 28, 2023
Merged
Conversation
legacyPlayerLocaleReference flag
Member
Author
|
Member
Author
|
1.4 will support conversion between legacy messages and miniMessage: example using the AdventureAPI (1.4 or newer): //noinspection deprecation
AdventureAPI.get().registerLegacyMessage("message.key",
"&6This&o message&r&6 is a &4legacy &6&lmessage&&6r!",
LegacyMessageType.AMPERSAND);Please keep in mind that this should only be used if you are converting an existing resource to the core and do not want to use network-specific replacements! You can use message-based replacements like |
TureBentzin
commented
Feb 27, 2023
Bommels05
requested changes
Feb 27, 2023
Contributor
Bommels05
left a comment
There was a problem hiding this comment.
Again good work! This PR like the others brings new features and bugfixes to the Core and us one step closer to 2.0 Tandana and the Juligames.net release. There are just a few things that need chaning.
TureBentzin
commented
Feb 27, 2023
Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>
Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>
…Dealer.java Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>
…Type.java Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>
Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>
Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>
…ommandManager.java Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>
Bommels05
approved these changes
Feb 28, 2023
Contributor
Bommels05
left a comment
There was a problem hiding this comment.
As I already said again good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.