Version 1.5 by TureBentzin · Pull Request #28 · JuliGames/JuliGamesCore

TureBentzin · 2023-03-06T10:18:17Z

bugfixes
setIfAbsent for Configurations
Create ObjectHashtableToStringHashtableMapper.java
further steps for the CoreCacheAPI
Breaking: Minigames now autostart!! (Experimental)
fixed Stackwalker for MiniGame error logging
some experiments with error-prone

sorry

TureBentzin · 2023-03-08T09:35:16Z

I'm currently thinking about giving the MiniGame the ability to set a "startType" of some sort to make it easier to build MiniGames that are powered by a "LobbyPhase" and such ones that are running all the time and need to be started directly after the MiniGame was successfully loaded.

Currently the MiniGameAPI is not used over a wide range of projects, so it would be possible to make a breaking change.

Also i need to rethink the direct native integration of TimoCloud into the MiniGameAPI, maybe there should be a better way to integrate own and custom cloud systems into the communication and state providing service that is handled and managed by the MiniGame API. The API has currently only limited information about the MiniGame (There should be improvements). It should be possible to access the MiniGame and control it, also if the controller does not implement or know the (or a) MiniGameAPI.

If further support for different CloudSystems is implemented native into the Core (what is unlikely) then CloudNet2 and CloudNet3 need a native implementation. Other CloudSystems would need more research on their users and their features to allow them to be implemented into the Communication and State Provider Technology that is used by the MiniGameAPI to inform other Servers, Services and the Players about the current "state" the MiniGame is in.

TureBentzin

I added some additional information for the review process

Bommels05

I think you by now know what I would write here... Good Work and a few things to fix

Bommels05 · 2023-03-18T13:43:10Z

+     * @param section the section
+     * @return an OfflineConfiguration. Changes to this will not affect root
+     */
+    @ApiStatus.AvailableSince("1.5")


If this is in testing I would add a @ Experimental Annotation

this is not only for testing, but also for storing data temporarily or working with a local dataset. There are a lot of possibilities!

…e.java Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>

….java Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>

…Game.java Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>

…eters.java

…PI.java

…ionaryFeedInterpreter.java

removed the log entry that leaked the database credentials

into development

Added DurationFormatting

into development

Bommels05

👍

TureBentzin and others added 27 commits February 28, 2023 17:02

bump 1.5-SNAPSHOT

7896084

Delete identifier.sqlite

940674a

Update FallBackMessage.java

4852430

Delete ApiIntegrityTest.java

7e2c7c0

remove debugs

d9d58a5

sorry

add setIfAbsent

ad4d14b

Update Configuration.java

07d1e3a

fix naming

6c01f9a

Create ObjectHashtableToStringHashtableMapper.java

09482d7

add OfflineConfiguration to API

8a45e7e

Update CoreCacheApi.java

f1f9424

deprecate doWithData

1413ec8

add core check to API.get()

1e17791

add autostart to minigames

8af9f4e

fix #27

e5e1eb9

fix StackWalker bug

f4615d4

fixed isses with the APIProvider

4fc161f

add errorprone

5a7b8cd

add PreDefinedInsertionProcedure

e16f498

start fixing the SwitchingInsertionProcedure

5c80025

add javadoc

f9e1b68

add createSectionClone and new Interpreters

c68b65b

add Environment and Property Interpreter

c564eae

upgrade environment interpreter

776bf38

move dir

d05c4d1

Create HazelFeedMapInterpreter.java

7ccf4db

add customPropertyInterpreter

f740ff2

TureBentzin added 2 commits March 9, 2023 17:29

Break "load" method of MiniGames

6571958

Create GenericHashtableToStringHashtableMapper.java

ed9c003

Update DurationFormatUtils.java

c56135d

TureBentzin commented Mar 17, 2023

View reviewed changes

Bommels05 requested changes Mar 18, 2023

View reviewed changes

TureBentzin and others added 12 commits March 18, 2023 15:18

Update API/src/main/java/net/juligames/core/api/minigame/BasicMiniGam…

a21c937

…e.java Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>

Update Core/src/main/java/net/juligames/core/config/CoreConfiguration…

6054931

….java Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>

Update MiniGameAPI/src/main/java/net/juligames/core/minigame/api/Mini…

8cb34c9

…Game.java Co-authored-by: Bommels05 <69975756+Bommels05@users.noreply.github.com>

Update API/src/main/java/net/juligames/core/api/config/BuildInInterpr…

0fa586e

…eters.java

Update API/src/main/java/net/juligames/core/api/config/ConfigurationA…

caf4d1c

…PI.java

Update API/src/main/java/net/juligames/core/api/config/mapbacked/Dict…

ccb7980

…ionaryFeedInterpreter.java

fix #30

d2d32d3

removed the log entry that leaked the database credentials

fixed compiler issue

4f375be

fixed second compiler issue

acb4f0b

Update SwitchingInsertionProcedure.java

c13c820

Merge branch 'development' of https://github.com/JuliGames/JuliGamesCore

1a9993c

into development

some reformat

dbdaa04

TureBentzin mentioned this pull request Mar 22, 2023

Caching configuration not implemented #31

Closed

TureBentzin added 3 commits March 22, 2023 12:10

removed cachingConfiguration

fcee9d8

Add EntryInterpretation

b33ae1d

fix exception handeling with entry interpretation

85474c9

TureBentzin requested a review from Bommels05 March 22, 2023 16:01

TureBentzin and others added 8 commits March 22, 2023 17:20

Update DurationFormatUtils.java

8dfef5f

integrate the Factories more

ccfc2be

Update EnvironmentVariable.java

634ef92

Delete Transaction.java

60c01e9

removed Experimental Status

2e6aa0b

Merge pull request #32 from JuliGames/duration-format

18a32ee

Added DurationFormatting

fixed some bugs

10af82a

Merge branch 'development' of https://github.com/JuliGames/JuliGamesCore

8e2a353

into development

Bommels05 approved these changes Mar 23, 2023

View reviewed changes

TureBentzin merged commit 2873eea into main Mar 23, 2023

Conversation

TureBentzin commented Mar 6, 2023

Uh oh!

TureBentzin commented Mar 8, 2023

Uh oh!

TureBentzin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bommels05 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Bommels05 Mar 18, 2023

Choose a reason for hiding this comment

Uh oh!

TureBentzin Mar 18, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bommels05 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants