Fix #119 to work regardless of data scaling #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` rather than an absolute tolerance
Member
|
Thanks for this! |
giopaglia
pushed a commit
to giopaglia/ModalDecisionTrees.jl
that referenced
this pull request
Nov 27, 2022
Fix JuliaAI#119 to work regardless of data scaling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks so much for the fast merge on #119
I missed that the added check is not robust to the scaling of the data. This fixes that by using
isapproxrather than an absolute tolerance, so it should work consistently across inputs.Sorry for the noise and missing this, and thanks again!