-
Notifications
You must be signed in to change notification settings - Fork 102
Add method build_forest(model, ...) to add trees to existing model
#216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add n_features accessor function for Ensemble
rikhuijzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool feature
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #216 +/- ##
==========================================
+ Coverage 87.99% 88.15% +0.16%
==========================================
Files 10 10
Lines 1249 1266 +17
==========================================
+ Hits 1099 1116 +17
Misses 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@rikhuijzer Could you please take a second look? |
rikhuijzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rikhuijzer Could you please take a second look?
Sorry for delayed response. I was away from keyboard in the weekend.
Looks good to me. Thanks for incorporating the comments
Sounds healthy to me. I am often away from keyboard on weekend. It's just that my weekend finishes earlier than yours 🌐 🥝 😄 Thanks for the prompt review, @rikhuijzer |
Closes #213.
You can now do this:
New docstring below.
Return an updated version of
modelwith additionaln_trees=options[2]added to theforest. Here
optionsandkeyword_optionsare as for the regularbuild_forestmethod,which excludes the
modelargument.Even if training data is the same in all
build_forestcalls, it is not practicallypossible to guarantee adding trees in steps is identical to adding them all at once,
because of the way random number generators are generated and used. But in all other
respects these approaches are equivalent.
Example
The call
is approximately equivalent to