Skip to content

Modify model_get to include apply parameter #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ablaom merged 3 commits into from
Apr 29, 2026
Merged

Modify model_get to include apply parameter #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9420a80
Modify model_get to include apply parameter
ablaom Apr 28, 2026
23fb1da
spelling
ablaom Apr 28, 2026
4afe006
spelling
ablaom Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/learners/gradient_descent.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ replacement for :epochs is specified, or `Δepochs` is negative, instead return
Return an updated model, with the weights and bias of the previously learned perceptron
used as the starting state in new gradient descent updates. Adopt any specified
hyperparameter `replacements` (properties of `LearnAPI.learner(model)`). Exactly `n` new
epochs are applied, where `n = model.epochs` unless this explictly changed in
epochs are applied, where `n = model.epochs` unless this explicitly changed in
`replacements`.

"""
Expand Down
2 changes: 1 addition & 1 deletion src/learners/static_algorithms.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ rejected(model::FancySelectorFitted) = model.rejected
LearnAPI.fit(learner::FancySelector; verbosity=LearnAPI.default_verbosity()) =
FancySelectorFitted(learner)

# output the filtered table and add `rejected` field to model (mutatated!)
# output the filtered table and add `rejected` field to model (mutated!)
function LearnAPI.transform(model::FancySelectorFitted, X)
table = Tables.columntable(X)
names = Tables.columnnames(table)
Expand Down
2 changes: 1 addition & 1 deletion src/tools.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ learner_get(learner, data, apply=identity) =
get(learner, data, LearnAPI.data_interface(learner), apply)

"""
model_get(model, data)
model_get(model, data; apply=identity)

*Private method.*

Expand Down
Loading