Implement MLJ inverse_transform #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OkonSamuel
reviewed
Nov 6, 2020
Member
|
Thanks a lot @Kolaru. |
Author
|
Everything should be good now. |
revert changes to `Tuple{MFitResultType{Float64}, Matrix{Float64}})` to try an avoid build error on julia v1.0
OkonSamuel
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement the
inverse_transforminterface for the decomposition method which have areconstructmethod.In addition I used a bit of metaprograming to remove a bit of duplicated code in the interfaces.