test linear models with table input instead of matrix input #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x input. 2. For multi-target linear and ridge regression add tests to ensure features of predicted target table and training target table are same
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 85.71% 85.84% +0.13%
==========================================
Files 5 5
Lines 217 219 +2
==========================================
+ Hits 186 188 +2
Misses 31 31
Continue to review full report at Codecov.
|
ablaom
reviewed
Oct 11, 2020
Member
ablaom
left a comment
ablaom
left a comment
There was a problem hiding this comment.
This looks good, many thanks!!
However, it seems that more than tests are being altered here. Is the new src/ code just a cleanup or a genuine bug fix?
Member
Author
|
it's a bug fix that was detected when i updated the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously tests on linear models were carried out using matrix input these lead to a bug in the table output gotten from these models . This PR fixes this by
testing linear and ridge regression with table input instead of matrix input.
adding tests for multi-target linear and ridge regression to ensure features of predicted target table and training target table are same
cc.@ablaom.