update fitted params for naive_bayes and linear discriminant analysis

[OkonSamuel]

closes #53

cc. @ablaom

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (9d9f4dc) to head (685b643).
Report is 57 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev      #55      +/-   ##
==========================================
+ Coverage   86.95%   87.43%   +0.48%     
==========================================
  Files          12       12              
  Lines         207      207              
==========================================
+ Hits          180      181       +1     
+ Misses         27       26       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ablaom]

@OkonSamuel Thanks for the prompt attention.

Can you please remove this line and the one below to revert testing of the NB model?

[ablaom]

Looks good. Thanks for attention to some previously overlooked detail.

I'm inclined to make this a breaking release, to be safe, because of the default value changes. But I would like to be sure there aren't any more we have missed. What do you think?

[ablaom]

@OkonSamuel Maybe we missed a hyperparameter name change: #56 (comment) ??

[OkonSamuel]

@OkonSamuel Maybe we missed a hyperparameter name change: #56 (comment) ??

No, not really. It's actually a deprecation I left there. I plan on removing it when python sklearn releases v1.4