Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #60 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 13 13
Lines 264 264
=======================================
Hits 251 251
Misses 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ablaom
left a comment
There was a problem hiding this comment.
@tylerjthomas9 Thanks for this contribution and your patience for a review.
Is it the case that you are only removing parameters that are already flagged as deprecated in sk 1.2?
Assuming the answer is yes, this is good to go. Please go ahead a tag a new release.
Yes, just the minimum to make sklearn v1.3 run without errors. We will have to do similar things when v1.4 and v1.5 come out. |
I have removed all the items that were removed from
scikit-learn@v1.3and added two comments for removingn_iterfor linear models inv1.5.I also removed a comment about using
PyCall.jlthat was leftover from before the transition.At some point, we should also expand the model support to include newer
scikit-learnadditions such asHistGradientBoostingClassifier.v1.3.0Patch Notes