Skip to content

scikit-learn v1.3 support#60

Merged
tylerjthomas9 merged 2 commits intoJuliaAI:devfrom
tylerjthomas9:scikit-learn-v1.3
Jul 19, 2023
Merged

scikit-learn v1.3 support#60
tylerjthomas9 merged 2 commits intoJuliaAI:devfrom
tylerjthomas9:scikit-learn-v1.3

Conversation

@tylerjthomas9
Copy link
Copy Markdown
Collaborator

@tylerjthomas9 tylerjthomas9 commented Jul 8, 2023

I have removed all the items that were removed from scikit-learn@v1.3 and added two comments for removing n_iter for linear models in v1.5.

I also removed a comment about using PyCall.jl that was leftover from before the transition.

At some point, we should also expand the model support to include newer scikit-learn additions such as HistGradientBoostingClassifier.

v1.3.0 Patch Notes

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (cd49440) to head (a3a668a).
Report is 34 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #60   +/-   ##
=======================================
  Coverage   95.07%   95.07%           
=======================================
  Files          13       13           
  Lines         264      264           
=======================================
  Hits          251      251           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylerjthomas9 Thanks for this contribution and your patience for a review.

Is it the case that you are only removing parameters that are already flagged as deprecated in sk 1.2?

Assuming the answer is yes, this is good to go. Please go ahead a tag a new release.

@tylerjthomas9
Copy link
Copy Markdown
Collaborator Author

Is it the case that you are only removing parameters that are already flagged as deprecated in sk 1.2?

Yes, just the minimum to make sklearn v1.3 run without errors. We will have to do similar things when v1.4 and v1.5 come out.

@tylerjthomas9 tylerjthomas9 merged commit f2395ea into JuliaAI:dev Jul 19, 2023
@tylerjthomas9 tylerjthomas9 deleted the scikit-learn-v1.3 branch January 6, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants