Skip to content

Conversation

@blegat
Copy link
Member

@blegat blegat commented Nov 7, 2018

No description provided.

@blegat blegat requested a review from saschatimme November 7, 2018 10:58
@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #102 into master will increase coverage by 0.89%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   83.55%   84.45%   +0.89%     
==========================================
  Files          16       16              
  Lines         590      579      -11     
==========================================
- Hits          493      489       -4     
+ Misses         97       90       -7
Impacted Files Coverage Δ
src/show.jl 72.22% <85.71%> (+4.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c90e917...f31c298. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 84.429% when pulling f31c298 on bl/latexprint into c90e917 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 84.429% when pulling f31c298 on bl/latexprint into c90e917 on master.

@coveralls
Copy link

coveralls commented Nov 7, 2018

Coverage Status

Coverage increased (+0.9%) to 84.429% when pulling f31c298 on bl/latexprint into c90e917 on master.

@saschatimme
Copy link
Collaborator

Do we really want to add $$s for every latex output? Does this help in Jupyter notebooks?

@blegat
Copy link
Member Author

blegat commented Nov 7, 2018

Yes, with Jupyter, if you do not add $$ then the polynomial is not displayed as math but just as text x_{1}^{2}...

@saschatimme
Copy link
Collaborator

Well, then great fix :)

@saschatimme saschatimme merged commit fd3c42e into master Nov 7, 2018
@saschatimme saschatimme deleted the bl/latexprint branch November 7, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants