Skip to content

Conversation

@icweaver
Copy link
Member

@icweaver icweaver commented Oct 26, 2025

What's changed

  • switch to [workspace]
  • use ParallelTestRunner
  • refactor tests using reusable workflow

A few things I like:

  • The status of compat tests on the release and dev versions of our packages can now be seen as individual badges on the README
image
  • Related to this, we can now run these tests at different frequencies if we want (e.g., release tested once a week, dev once a day)

Things to consider

@cgarling brought up a great point about wanting to avoid increasing the maintenance burden that would have been introduced if we went with splitting out testing on stable and pre-release versions of Julia.

In this similar vein, I decided that splitting out testing the compatibility of our released and development versions of our JuliaAstro packages (i.e., master/main) is still warranted because we really do want to have both of those bits information easily accessible. My hope is that introducing the reusable github action workflow mitigates the maintenance burden that this would introduce

@icweaver icweaver changed the title Reorg ci project Reorg CI + project Oct 26, 2025
@icweaver icweaver marked this pull request as ready for review October 31, 2025 03:51
Copy link
Member

@cgarling cgarling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I'm not very familiar with how this repo works so some of this is a little beyond me but I don't see any significant issues. Having the reusable parts in CI.yml that is called by CI_dev and CI_release seems like a good compromise.

@cgarling
Copy link
Member

cgarling commented Nov 1, 2025

Do the tests pass if you run on Julia 1.11?

Co-authored-by: Chris Garling <chris.t.garling@gmail.com>
@icweaver
Copy link
Member Author

icweaver commented Nov 1, 2025

TBH I'm not very familiar with how this repo works so some of this is a little beyond me but I don't see any significant issues.

That's a failing on my part, I should really flesh out the developer docs some more. Saving a to-do here for that #177

Do the tests pass if you run on Julia 1.11?

ooh, thank you for reminding me to update the versions we test on. Will follow up

  • Update: Should be in now. bump Julia versions #178. There's currently some duplication with 1 == pre == v1.12 rn, but I figured having this as a set it and forget it setting with pre is preferable to manually needing to go in an update things when v1.13 comes out

@icweaver
Copy link
Member Author

icweaver commented Nov 2, 2025

Cool, looks like things are passing on Julia v10 and v11 on the dev versions of our packages. I'm liking the extra granularity we are getting now!

@icweaver icweaver merged commit b8b6215 into main Nov 2, 2025
4 of 10 checks passed
@icweaver icweaver deleted the reorg-ci-project branch November 2, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants