-
Notifications
You must be signed in to change notification settings - Fork 17
Reorg CI + project #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorg CI + project #172
Conversation
cgarling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I'm not very familiar with how this repo works so some of this is a little beyond me but I don't see any significant issues. Having the reusable parts in CI.yml that is called by CI_dev and CI_release seems like a good compromise.
|
Do the tests pass if you run on Julia 1.11? |
Co-authored-by: Chris Garling <chris.t.garling@gmail.com>
That's a failing on my part, I should really flesh out the developer docs some more. Saving a to-do here for that #177
ooh, thank you for reminding me to update the versions we test on. Will follow up
|
|
Cool, looks like things are passing on Julia v10 and v11 on the dev versions of our packages. I'm liking the extra granularity we are getting now! |
What's changed
[workspace]A few things I like:
Things to consider
@cgarling brought up a great point about wanting to avoid increasing the maintenance burden that would have been introduced if we went with splitting out testing on stable and pre-release versions of Julia.
In this similar vein, I decided that splitting out testing the compatibility of our released and development versions of our JuliaAstro packages (i.e.,
master/main) is still warranted because we really do want to have both of those bits information easily accessible. My hope is that introducing the reusable github action workflow mitigates the maintenance burden that this would introduce