Add rules for atan2, hypot, mod, and rem. Addresses #15. #16
Conversation
src/rules.jl
Outdated
| @define_diffrule atan2(x, y) = :($y / ($x*$x + $y*$y)), :(-$x / ($x*$x + $y*$y)) | ||
| @define_diffrule hypot(x, y) = :($x / hypot($x, $y)), :($y / hypot($x, $y)) | ||
| @define_diffrule mod(x, y) = :(1), :(-trunc($x / $y)) | ||
| @define_diffrule rem(x, y) = :(1), :(-trunc($x / $y)) |
There was a problem hiding this comment.
These need fixing. mod and rem are not identical. Besides, contrary to my belief following an initial quick study of the cases, these rules don't work for all sign combinations for either function.
There was a problem hiding this comment.
Nope. I was wrong about being wrong. 😄 The rule works for rem, but trunc needs to be changed to floor for mod.
|
The rules for Should they be modified to give |
I think so, might as well have them be correct. We could change the rule to something like Thanks for this! |
|
Oh, forgot to do the same for the first partial. |
|
I'll squash shortly. |
src/rules.jl
Outdated
| # mod | ||
| # hypot | ||
| # atan2 | ||
| @define_diffrule atan2(x, y) = :($y / ($x*$x + $y*$y)), :(-$x / ($x*$x + $y*$y)) |
There was a problem hiding this comment.
Can we switch x * x and y * y to x^2 and y^2, just to keep in style with the other rules? Thanks!
twadleigh
force-pushed
the
pull-request/9edaf9ec
branch
from
59b55ba to
6220c2f
Compare
2 participants
Addresses #15.