fix: fix reference used for inline linear SCC diffcache#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreallocationTools.get_tmpneeds a value passed to it to know whether to return a dual buffer or not. Previously,findfirst(!SU.isconst, A)ignored the fact thatA isa Matrix{Num}and needsunwrap. However,!isconstwill still find parameters, which won't be duals even if unknowns are.iscallsuffers from the same problem. Usingsearch_variables!and/orqueryto find entries ofA/bwith unknowns is expensive. This approach prefers to find a differential variable and use that. The downside is that this may use a dual buffer even ifAorbdon't have duals, but shouldn't be too bad.