Skip to content

Conversation

@baggepinnen
Copy link
Member

closes #611

@baggepinnen baggepinnen requested a review from mfalt January 26, 2022 07:43
@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 9/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.003 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
❌ 0.042 Reference New
✔️ 0.006 Reference New
✔️ 0.012 Reference New

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #612 (dcc7f99) into master (094983a) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

❗ Current head dcc7f99 differs from pull request most recent head d059caa. Consider uploading reports for the commit d059caa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   86.81%   86.81%   -0.01%     
==========================================
  Files          31       31              
  Lines        3239     3245       +6     
==========================================
+ Hits         2812     2817       +5     
- Misses        427      428       +1     
Impacted Files Coverage Δ
src/pid_design.jl 78.73% <90.90%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 094983a...d059caa. Read the comment docs.

@baggepinnen
Copy link
Member Author

Hmm, the new default limits are no good :/

@baggepinnen baggepinnen merged commit 699b36e into master Jan 27, 2022
@baggepinnen baggepinnen deleted the rlocusfix branch January 27, 2022 06:16
@albheim albheim mentioned this pull request Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rlocusplot with zero excess

3 participants