Skip to content

Conversation

@baggepinnen
Copy link
Member

Avoinds many problems of porrly conditioned numerics

Closes #419 (I tried the simulation as well and it was no problem with this PR)

@JuliaControlBot
Copy link

This is an automated message.
Plots were compared to references. 9/11 images have changed, see differences below.
After pulling this PR, please update the reference images by creating a PR to ControlExamplePlots.jl here.

Difference Reference Image New Image
✔️ 0.003 Reference New
✔️ 0.003 Reference New
✔️ 0.0 Reference New
✔️ 0.001 Reference New
✔️ 0.0 Reference New
✔️ 0.0 Reference New
❌ 0.042 Reference New
✔️ 0.006 Reference New
✔️ 0.011 Reference New

Avoids many problems of porrly conditioned numerics
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #623 (e86aa14) into master (285053b) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
+ Coverage   86.75%   86.78%   +0.02%     
==========================================
  Files          31       31              
  Lines        3247     3253       +6     
==========================================
+ Hits         2817     2823       +6     
  Misses        430      430              
Impacted Files Coverage Δ
src/types/conversion.jl 97.03% <100.00%> (+0.74%) ⬆️
src/types/SisoTfTypes/SisoRational.jl 79.51% <0.00%> (-0.49%) ⬇️
src/matrix_comps.jl 92.99% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285053b...e86aa14. Read the comment docs.

@baggepinnen baggepinnen merged commit 6a89280 into master Jan 28, 2022
@baggepinnen baggepinnen deleted the baldefault branch January 28, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stable system with unstable step response

3 participants