Perfomance Improvments for definition
#121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main change is not calling `length(src)` which is linear in `src`. `linestarts` could be converted to a StaticArray with size 21 but I don't think that would do much.
Also remove type assertion just in case
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #121 +/- ##
==========================================
- Coverage 88.82% 88.58% -0.25%
==========================================
Files 3 3
Lines 367 368 +1
==========================================
Hits 326 326
- Misses 41 42 +1
☔ View full report in Codecov by Sentry. |
|
This pr Zentrik#3 just removes the |
|
I noticed that other was closed, does that mean this one offers significant extra benefits? |
|
Sorry, I forgot about that. I closed it because that was on my personal repo, I've created a pr for this repo #122. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main performance improvement is from no longer calling
length(src)which is O(n). I don't understand why that was ever being called as starting the parse from there shouldn't give anything useful. Also, I don't see any tests failing here or in TypedSyntax after that change so I think it should be fine.Around a 5-10% improvement for long files.