Improve performance #122
Merged
Improve performance #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 88.33% 88.91% +0.58%
==========================================
Files 3 3
Lines 360 370 +10
==========================================
+ Hits 318 329 +11
+ Misses 42 41 -1
☔ View full report in Codecov by Sentry. |
timholy
approved these changes
Aug 22, 2023
|
I'm actually OK with either, but prefer (unless there's a substantial difference) the less intrusive change because it keeps the code a tiny bit simpler. But you can pick which to merge. |
|
There only seems to be a 1% difference between the prs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler version of other pr.