Use upstream functionality for fixing stdlib paths (take 2) #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to automatically get new functionality like JuliaLang/julia#57274.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 89.50% 88.94% -0.56%
==========================================
Files 3 3
Lines 381 407 +26
==========================================
+ Hits 341 362 +21
- Misses 40 45 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
serenity4
added a commit
that referenced
this pull request
Apr 25, 2025
Forgot to add these before merging #139
timholy
added a commit
to serenity4/JuliaInterpreter.jl
that referenced
this pull request
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In take 1 I removed the
maybe_fixup_stdlib_pathbut that is actually used by e.g. JuliaInterpreter. This should fx the Revise errors that take 1 encountered.