Support and test all v1 Julia versions#24
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 79.34% 79.51% +0.16%
==========================================
Files 2 2
Lines 368 371 +3
==========================================
+ Hits 292 295 +3
Misses 76 76
Continue to review full report at Codecov.
|
|
In general, I think we only need to test the LTS and latest minor release. So just '1.0' and '1'. People on minor releases must update each release. If they don't like that, use the LTS instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the support for Julia 1.0, 1.1 and 1.2. The Zygote over ForwardDiff Hessian tests are failing for Zygote mutation-related reasons that seem to be fixed in Julia 1.3 and above. Since this is a Zygote issue for Julia < 1.3, I just avoid testing this case instead of fixing it. This issue fixes #18.