Skip to content

Add convert for AbstractZero #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2020
Merged

Add convert for AbstractZero #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35982e5
Add convert for AbstractZero
Nov 20, 2020
dd4eba9
patch bump
Nov 20, 2020
a3b5282
Update src/differentials/abstract_zero.jl
mzgubic Nov 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRulesCore"
uuid = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
version = "0.9.19"
version = "0.9.20"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand Down
2 changes: 2 additions & 0 deletions src/differentials/abstract_zero.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ Base.adjoint(z::AbstractZero) = z
Base.transpose(z::AbstractZero) = z
Base.:/(z::AbstractZero, ::Any) = z

Base.convert(::Type{T}, x::AbstractZero) where T <: Number = zero(T)

"""
Zero() <: AbstractZero

Expand Down
6 changes: 6 additions & 0 deletions test/differentials/abstract_zero.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@
@test complex(z, z) === z
@test complex(z, 2.0) === Complex{Float64}(0.0, 2.0)
@test complex(1.5, z) === Complex{Float64}(1.5, 0.0)

@test convert(Int64, Zero()) == 0
@test convert(Float64, Zero()) == 0.0
end

@testset "DoesNotExist" begin
Expand Down Expand Up @@ -96,5 +99,8 @@
@test f(dne) === dne
end
@test dne / 2 === dne / [1, 3] === dne

@test convert(Int64, DoesNotExist()) == 0
@test convert(Float64, DoesNotExist()) == 0.0
end
end