-
Notifications
You must be signed in to change notification settings - Fork 64
Update badges to show build status and coverage now we use GithubActions #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nickrobinson251
commented
Feb 10, 2021
- noticed these were out of date when reviewing make Julia nightly CI a separate workflow #302
|
|
||
| [](https://travis-ci.org/JuliaDiff/ChainRulesCore.jl) | ||
| [](https://coveralls.io/github/JuliaDiff/ChainRulesCore.jl?branch=master) | ||
| [](https://juliaci.github.io/NanosoldierReports/pkgeval_badges/report.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added this one a while ago, so we could see if we pass on Julia Nightly version (without running it ourselves as part of the daily cron job), but AFAIK no one ever looks at it and it just means we occassionally have a "failing" badge on the README (which isn't great).
If anyone thinks we should keep the PkgEval let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like being able to tell at first first glance whether I can expect a package to work on Julia master, but I will admit that I am probably not that representative of the average user, so I don't really care.
| [](https://travis-ci.org/JuliaDiff/ChainRulesCore.jl) | ||
| [](https://coveralls.io/github/JuliaDiff/ChainRulesCore.jl?branch=master) | ||
| [](https://juliaci.github.io/NanosoldierReports/pkgeval_badges/report.html) | ||
| [](https://github.com/JuliaDiff/ChainRulesCore.jl/actions?query=workflow:CI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workflows/CI/badge.svg (linking to actions?query=workflow:CI) so that we're green if the CI action passes (i.e. ignore the JuliaNightly action)
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
- Coverage 89.39% 85.92% -3.48%
==========================================
Files 13 13
Lines 462 412 -50
==========================================
- Hits 413 354 -59
- Misses 49 58 +9
Continue to review full report at Codecov.
|