Skip to content

Conversation

@nickrobinson251
Copy link
Contributor


[![Travis](https://travis-ci.org/JuliaDiff/ChainRulesCore.jl.svg?branch=master)](https://travis-ci.org/JuliaDiff/ChainRulesCore.jl)
[![Coveralls](https://coveralls.io/repos/github/JuliaDiff/ChainRulesCore.jl/badge.svg?branch=master)](https://coveralls.io/github/JuliaDiff/ChainRulesCore.jl?branch=master)
[![PkgEval](https://juliaci.github.io/NanosoldierReports/pkgeval_badges/C/ChainRulesCore.svg)](https://juliaci.github.io/NanosoldierReports/pkgeval_badges/report.html)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i added this one a while ago, so we could see if we pass on Julia Nightly version (without running it ourselves as part of the daily cron job), but AFAIK no one ever looks at it and it just means we occassionally have a "failing" badge on the README (which isn't great).

If anyone thinks we should keep the PkgEval let me know

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like being able to tell at first first glance whether I can expect a package to work on Julia master, but I will admit that I am probably not that representative of the average user, so I don't really care.

[![Travis](https://travis-ci.org/JuliaDiff/ChainRulesCore.jl.svg?branch=master)](https://travis-ci.org/JuliaDiff/ChainRulesCore.jl)
[![Coveralls](https://coveralls.io/repos/github/JuliaDiff/ChainRulesCore.jl/badge.svg?branch=master)](https://coveralls.io/github/JuliaDiff/ChainRulesCore.jl?branch=master)
[![PkgEval](https://juliaci.github.io/NanosoldierReports/pkgeval_badges/C/ChainRulesCore.svg)](https://juliaci.github.io/NanosoldierReports/pkgeval_badges/report.html)
[![Build Status](https://github.com/JuliaDiff/ChainRulesCore.jl/workflows/CI/badge.svg)](https://github.com/JuliaDiff/ChainRulesCore.jl/actions?query=workflow:CI)
Copy link
Contributor Author

@nickrobinson251 nickrobinson251 Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflows/CI/badge.svg (linking to actions?query=workflow:CI) so that we're green if the CI action passes (i.e. ignore the JuliaNightly action)

@codecov-io
Copy link

Codecov Report

Merging #303 (7e9a07b) into master (a8f110e) will decrease coverage by 3.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   89.39%   85.92%   -3.48%     
==========================================
  Files          13       13              
  Lines         462      412      -50     
==========================================
- Hits          413      354      -59     
- Misses         49       58       +9     
Impacted Files Coverage Δ
src/compat.jl 0.00% <0.00%> (-55.56%) ⬇️
src/differentials/thunks.jl 56.52% <0.00%> (-7.48%) ⬇️
src/differentials/composite.jl 77.45% <0.00%> (-5.01%) ⬇️
src/ruleset_loading.jl 92.10% <0.00%> (-3.64%) ⬇️
src/accumulation.jl 96.66% <0.00%> (-0.40%) ⬇️
src/differentials/abstract_zero.jl 93.75% <0.00%> (-0.37%) ⬇️
src/rule_definition_tools.jl 94.17% <0.00%> (-0.14%) ⬇️
src/differential_arithmetic.jl 96.15% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f110e...7e9a07b. Read the comment docs.

@nickrobinson251 nickrobinson251 merged commit d6be628 into master Feb 10, 2021
@nickrobinson251 nickrobinson251 deleted the npr/gha-badges branch February 10, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants