Skip to content

Conversation

@mzgubic
Copy link
Member

@mzgubic mzgubic commented Mar 17, 2021

No description provided.

Copy link
Member Author

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why github is picking on y\bar, I just made two small changes

return y, PullbackMemory(sin; cx=cx)
end
(pb::PullbackMemory)(ȳ) = * pb.cx
(pb::PullbackMemory{typeof(sin)})(ȳ) = ȳ * pb.cx
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed this

It's not too bad for this simple example with just one or two things to remember.
For more complicated multi-argument functions, which we will show below, you often end up needing to remember half a dozen things, like sizes and indices relating to each input/output, so it gets a little more fiddly to make sure you remember all the things you need to and give them the same name in both places.
_Is there a way we can automatically just have all the things we use remembered for us?_
_Is there a way we can automatically just have all the things we use remembered for us?_
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and added a space here

@mzgubic mzgubic merged commit 74201e6 into master Mar 17, 2021
@mzgubic mzgubic deleted the mzgubic-patch-1 branch March 17, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants