Skip to content

Conversation

@oxinabox
Copy link
Member

solves #317, replaces #318. Same change to src but with tests

@devmotion do you want to review?

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
@oxinabox oxinabox merged commit 63de708 into master Mar 24, 2021
@oxinabox oxinabox deleted the ox/scope branch March 24, 2021 17:05
@simeonschaub
Copy link
Member

This will still fail if one only does using ChainRulesCore: @scalar_rule. I think it would be better to just interpolate rrule directly into the AST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants