canonicalize Composite{Any} #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 25, 2021 13:51
mzgubic
commented
Mar 25, 2021
mzgubic
commented
Mar 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
- Coverage 89.72% 89.58% -0.15%
==========================================
Files 13 13
Lines 477 480 +3
==========================================
+ Hits 428 430 +2
- Misses 49 50 +1
Continue to review full report at Codecov.
|
oxinabox
reviewed
Mar 25, 2021
oxinabox
approved these changes
Mar 25, 2021
Member
oxinabox
left a comment
oxinabox
left a comment
There was a problem hiding this comment.
I feel like we need to document this somewhere.
Co-authored-by: Lyndon White <oxinabox@ucc.asn.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #321
I don't think it would be easy to make it work for general abstract types because of dispatch? It's not possible to dispatch on whether type is abstract or concrete right?