Pin reverse dependency tests to 1.5 #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 13 13
Lines 472 472
=======================================
Hits 424 424
Misses 48 48 Continue to review full report at Codecov.
|
mzgubic
approved these changes
Mar 29, 2021
Member
mzgubic
left a comment
mzgubic
left a comment
There was a problem hiding this comment.
LGTM, we need to remember to change it back once tests pass on 1.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChainRules.jl is failing tests in 1.6 because of type inference.
til we get around to fixing that seems best to keep our integration tests running on 1.5