Skip to content

Implement Base.:(==) for thunks #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Implement Base.:(==) for thunks #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6488bb1
implement == for thunks
Jun 9, 2021
f6d6bdd
make test more explicit
Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRulesCore"
uuid = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
version = "0.10.2"
version = "0.10.3"

[deps]
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
Expand Down
4 changes: 4 additions & 0 deletions src/differentials/thunks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ end
return element, (val, new_state)
end

Base.:(==)(a::AbstractThunk, b::AbstractThunk) = unthunk(a) == unthunk(b)
Copy link
Member

@oxinabox oxinabox Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some special case we might be able to optimize the positive cases like a===b to avoid unthunking.
idk if worth it though

Base.:(==)(a::AbstractThunk, b) = unthunk(a) == b
Base.:(==)(a, b::AbstractThunk) = a == unthunk(b)

"""
@thunk expr

Expand Down
6 changes: 6 additions & 0 deletions test/differentials/thunks.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
@testset "Thunk" begin
@test @thunk(3) isa Thunk

@testset "==" begin
@test @thunk(3.2) == InplaceableThunk(@thunk(3.2), x -> x + 3.2)
Copy link
Member Author

@mzgubic mzgubic Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have this? Or should we separate between Thunks and InplaceableThnks?

Copy link
Member

@oxinabox oxinabox Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(@thunk(3.2)) == 3.2

Inplacable(@thunk(3.2), _->error("this shouldn;t be hit")) == 3.2

Thus by transitivity thye must be equal to each other

@test @thunk(3.2) == 3.2
@test 3.2 == InplaceableThunk(@thunk(3.2), x -> x + 3.2)
end

@testset "show" begin
rep = repr(Thunk(rand))
@test occursin(r"Thunk\(.*rand.*\)", rep)
Expand Down