fix iteration of thunks #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Jun 16, 2021
| next isa Nothing && return nothing | ||
| element, new_state = next | ||
| return element, (val, new_state) | ||
| end |
Member
There was a problem hiding this comment.
we may want to rename val to obj or underlying_object or something.
so it is clear that it is the object actually being iterated rather than being a value from the object being iterated
oxinabox
approved these changes
Jun 16, 2021
simeonschaub
approved these changes
Jun 16, 2021
src/differentials/thunks.jl
Outdated
| @inline function Base.iterate(::AbstractThunk, (val, state)) | ||
| element, new_state = iterate(val, state) | ||
| next = iterate(val, state) | ||
| next isa Nothing && return nothing |
Member
There was a problem hiding this comment.
Doesn't really matter, but this is generally more idiomatic:
Suggested change
| next isa Nothing && return nothing | |
| next === nothing && return nothing |
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 87.42% 88.86% +1.44%
==========================================
Files 14 14
Lines 485 485
==========================================
+ Hits 424 431 +7
+ Misses 61 54 -7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369