Skip to content

Pushforwards and pullbacks for everyone#113

Merged
gdalle merged 1 commit intomainfrom
gd/fake
Mar 27, 2024
Merged

Pushforwards and pullbacks for everyone#113
gdalle merged 1 commit intomainfrom
gd/fake

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Mar 27, 2024

Core

  • Implement pushforward based on pullback and pullback based on pushforward => if you forget both, you get a StackOverflowError
  • Make derivative a simple pushforward of 1 and gradient a simple pullback of 1
  • Replace traits ...Supported with ...Fast, because some backends may support pushforwards and pullbacks
  • Replace functions supports_... with ..._performance

Tests

  • Split testing from benchmarking
  • Remove allocation tests
  • Test all scenarios on pushforwards and pullbacks
  • Add optional logging to test function instead of test file

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.12403% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 93.13%. Comparing base (fb07d7f) to head (636b5e1).

Files Patch % Lines
src/traits.jl 90.90% 2 Missing ⚠️
.../DifferentiationInterfaceFastDifferentiationExt.jl 0.00% 1 Missing ⚠️
lib/DifferentiationInterfaceTest/src/tests/test.jl 92.30% 1 Missing ⚠️
src/backends.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   93.77%   93.13%   -0.64%     
==========================================
  Files          55       56       +1     
  Lines        1414     1399      -15     
==========================================
- Hits         1326     1303      -23     
- Misses         88       96       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 6155b2a into main Mar 27, 2024
@gdalle gdalle deleted the gd/fake branch March 27, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants