Skip to content

Right preparation for second order closures#122

Merged
gdalle merged 2 commits intomainfrom
gd/fix_second_order
Mar 31, 2024
Merged

Right preparation for second order closures#122
gdalle merged 2 commits intomainfrom
gd/fix_second_order

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Mar 31, 2024

Core

  • Prepare the inner backend with the variables from inside the closure, in hvp and second_derivative

Extensions

  • Add more overloads for FastDifferentiation

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.94%. Comparing base (21a96ea) to head (b05809c).

Files Patch % Lines
...faceZygoteExt/DifferentiationInterfaceZygoteExt.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   92.79%   93.94%   +1.14%     
==========================================
  Files          56       56              
  Lines        1666     1733      +67     
==========================================
+ Hits         1546     1628      +82     
+ Misses        120      105      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 50e2a52 into main Mar 31, 2024
@gdalle gdalle deleted the gd/fix_second_order branch March 31, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants