Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is motivated by a clean preparation of the HVP operator. It ended up leading to a revamp of the way extras work. The HVP preparation is still wasteful but improving it will be much easier now.
Core
BREAKING: Remove support for scalar input in the gradient and HVP operators
Define abstract supertypes for each operator:
PushforwardExtras,GradientExtras, etc.Define corresponding empty structs:
NoPushforwardExtras(),NoGradientExtras(), etc.Ensure that each operator only accepts extras of the right type
Define sensible default extras for higher-level operators
Extensions
No...Extrasin lieu ofextras::NothingTest