Skip to content

Fix mode for second order#205

Merged
gdalle merged 4 commits intomainfrom
gd/secondordermode
Apr 24, 2024
Merged

Fix mode for second order#205
gdalle merged 4 commits intomainfrom
gd/secondordermode

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Apr 24, 2024

Fix #204

Core

  • Define mode for SecondOrder by taking the mode of the outer backend

Tests

  • Add a benchmarking test for SecondOrder to avoid regressions

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (023a8ea) to head (3ca2ed9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   96.39%   95.90%   -0.50%     
==========================================
  Files          65       15      -50     
  Lines        3553     1562    -1991     
==========================================
- Hits         3425     1498    -1927     
+ Misses        128       64      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 32849b8 into main Apr 24, 2024
@gdalle gdalle deleted the gd/secondordermode branch April 24, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need mode method for SecondOrder

2 participants