Tapir Safe Mode

[willtebbutt]

Follow up from recent ADTypes PR -- this PR ensures that if someone asks for safe mode in when constructing AutoTapir, they get safe mode.

[willtebbutt]

Test failures because version 1.2 of ADTypes is not yet available.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (f66c0bc) to head (d9cbb3b).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files          74       74           
  Lines        3929     3929           
=======================================
  Hits         3738     3738           
  Misses        191      191           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gdalle]

The formatting check failed. Also you are polluting my test suite with @info messages, is there any way to get rid of them? Perhaps test the unsafe mode here, and both modes on your end?

[willtebbutt]

The formatting check failed.

Hmm yes, that does appear to be what's happening. Have you considered deploying ReviewDog e.g. as done in AbstractGPs in order to make any formatting issues + fixes appear in the PR?

Also you are polluting my test suite with @info messages, is there any way to get rid of them?

Hahaha, yes, I am doing that at present.

Perhaps test the unsafe mode here, and both modes on your end?

Yeah, that's probably the right thing to do. Will fix these problems now.

[gdalle]

Have you considered deploying ReviewDog e.g. as done in AbstractGPs in order to make any formatting issues + fixes appear in the PR?

From what I've seen, these tools can be extremely noisy and make tons of comments on a single commit, so I like having that check as part of my test suite. Especially when I work on rather ambitious PRs, which is often the case in DI

[willtebbutt]

From what I've seen, these tools can be extremely noisy and make tons of comments on a single commit, so I like having that check as part of my test suite. Especially when I work on rather ambitious PRs, which is often the case in DI

That's completely reasonable.

[willtebbutt]

Another bug on my end because testing whether something prints is hard. Will fix and then re-run the tests.

[gdalle]

The printing is not a problem for me, it's just a mild annoyance. Since the tests pass, can I merge and release this?

[willtebbutt]

Yes, please do. The next patch version of Tapir will fix the printing issue anyway.