Skip to content

Better seed handling in Jacobian and Hessian#334

Merged
gdalle merged 1 commit intomainfrom
gd/jac_batched_seeds
Jun 26, 2024
Merged

Better seed handling in Jacobian and Hessian#334
gdalle merged 1 commit intomainfrom
gd/jac_batched_seeds

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Jun 26, 2024

DI source

  • Prepare batched seeds in the preparation phase for Jacobian and Hessian
  • Remove products storage in the sparse version to imitate dense ones (reshape a view of the returned matrix instead)
  • Change extras handling in FromPrimitive backends (internals) to avoid ambiguities

DI tests

  • Test AutoReverseFromPrimitive with ForwardDiff

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 98.09524% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.75%. Comparing base (feb17b0) to head (f32fd53).
Report is 1 commits behind head on main.

Files Patch % Lines
DifferentiationInterface/src/sparse/jacobian.jl 93.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   96.73%   96.75%   +0.02%     
==========================================
  Files         101      101              
  Lines        4840     4811      -29     
==========================================
- Hits         4682     4655      -27     
+ Misses        158      156       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 8dc755b into main Jun 26, 2024
@gdalle gdalle deleted the gd/jac_batched_seeds branch June 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants