Remove FillArrays dependency by implementing custom OneElement#453
Merged
Remove FillArrays dependency by implementing custom OneElement#453
OneElement#453Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage 98.52% 98.53%
=======================================
Files 107 107
Lines 4271 4287 +16
=======================================
+ Hits 4208 4224 +16
Misses 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OneElementOneElement
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DI source
OneElementbasisandmultibasisinstead of the FillArrays versionCartesianIndiceswitheachindex, which may be faster. Note thatCartesianIndicesis kept for wrong-mode pushforwards and pullbacks.DI tests
OneElementandbasis@testsetfor scenario intactnessDI extensions
Load time before:
Load time after: