[BREAKING] Force use of Tangents in pushforward, pullback and hvp#455
Merged
[BREAKING] Force use of Tangents in pushforward, pullback and hvp#455
Tangents in pushforward, pullback and hvp#455Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
==========================================
- Coverage 98.53% 98.52% -0.01%
==========================================
Files 107 106 -1
Lines 4287 4265 -22
==========================================
- Hits 4224 4202 -22
Misses 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TangentsTangents in pushforward, pullback and hvp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Breaking change:
pushforward,pullbackandhvpno longer accept plain objects asdxordy: this argument must now be wrapped intoTangents.Tip
Since
Tangentsbecomes part of the public API, this also allows users to leverage batch mode directly. At the moment it is only useful with ForwardDiff, but we're working on adding Enzyme support.DI source
pushforward,pullbackandhvpto useTangentsand remove the fallbacks.Tangentsconstructor so that it acceptsVararg, also modify its second type parameterTangentslike indexing andmapDI extensions
TangentsconstructorDI docs
Tangentspart of the public API, enabling users to access batch modeDIT source
Scenarioconstructors so that they only acceptTangentsforpushforward,pullbackandhvp