Skip to content

Remove fallback backend -> SecondOrder(backend, backend)#459

Merged
gdalle merged 2 commits intomainfrom
gd/secondorder_fallback
Sep 8, 2024
Merged

Remove fallback backend -> SecondOrder(backend, backend)#459
gdalle merged 2 commits intomainfrom
gd/secondorder_fallback

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Sep 8, 2024

DI source

  • Use maybe_inner and maybe_outer to make the code for hvp and second_derivative work with standard backends too
  • Remove unnecessary fallback from backend to SecondOrder(backend, backend)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (1155218) to head (b83482a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   98.52%   98.51%   -0.01%     
==========================================
  Files         106      106              
  Lines        4265     4250      -15     
==========================================
- Hits         4202     4187      -15     
  Misses         63       63              
Flag Coverage Δ
DI 98.66% <100.00%> (-0.01%) ⬇️
DIT 98.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review September 8, 2024 08:14
@gdalle gdalle merged commit 2411653 into main Sep 8, 2024
@gdalle gdalle deleted the gd/secondorder_fallback branch September 8, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants