Update Tapir to use cached rules where possible#464
Update Tapir to use cached rules where possible#464gdalle merged 4 commits intoJuliaDiff:mainfrom willtebbutt:wct/update-tapir-interpreter-usage
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #464 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 106 106
Lines 4234 4234
=======================================
Hits 4172 4172
Misses 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Cool! The tests are probably gonna fail because Enzyme is acting up (EnzymeAD/Enzyme.jl#1804), once this is solved we'll re-run. |
|
Sounds good to me -- there's no particular rush because (I believe) this is strict improvement over what we already have. Would you like me to remove the patch bump and just incorporate this into the 0.6 release? |
|
Yeah we might as well. |
gdalle
left a comment
There was a problem hiding this comment.
This looks good, can you just bump the weakdep compat to the earliest version of Tapir supporting this?
We've recently added a feature to Tapir.jl which does some (very conservative) rule caching. In order to take advantage of this, I've upgraded the Tapir extension.
(The plan is still to rename Tapir.jl to something else, it's just taking a while. In the meantime, I'd like to ensure that this feature is rolled out).