Skip to content

Update Tapir to use cached rules where possible#464

Merged
gdalle merged 4 commits intoJuliaDiff:mainfrom
willtebbutt:wct/update-tapir-interpreter-usage
Sep 12, 2024
Merged

Update Tapir to use cached rules where possible#464
gdalle merged 4 commits intoJuliaDiff:mainfrom
willtebbutt:wct/update-tapir-interpreter-usage

Conversation

@willtebbutt
Copy link
Copy Markdown
Member

We've recently added a feature to Tapir.jl which does some (very conservative) rule caching. In order to take advantage of this, I've upgraded the Tapir extension.

(The plan is still to rename Tapir.jl to something else, it's just taking a while. In the meantime, I'd like to ensure that this feature is rolled out).

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (b3c9b0a) to head (2144f8c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         106      106           
  Lines        4234     4234           
=======================================
  Hits         4172     4172           
  Misses         62       62           
Flag Coverage Δ
DI 98.69% <ø> (ø)
DIT 98.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle
Copy link
Copy Markdown
Member

gdalle commented Sep 12, 2024

Cool! The tests are probably gonna fail because Enzyme is acting up (EnzymeAD/Enzyme.jl#1804), once this is solved we'll re-run.
Note that v0.6 still needs a bit of work so this won't get tagged right away. It's a breaking change and I wanna make sure I get it right.

@willtebbutt
Copy link
Copy Markdown
Member Author

Sounds good to me -- there's no particular rush because (I believe) this is strict improvement over what we already have.

Would you like me to remove the patch bump and just incorporate this into the 0.6 release?

@gdalle
Copy link
Copy Markdown
Member

gdalle commented Sep 12, 2024

Yeah we might as well.

Copy link
Copy Markdown
Member

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, can you just bump the weakdep compat to the earliest version of Tapir supporting this?

@gdalle gdalle changed the title Update Tapir to used cached rules where possible Update Tapir to use cached rules where possible Sep 12, 2024
@gdalle gdalle merged commit 41bade9 into JuliaDiff:main Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants