Skip to content

Remove use of custom isequal to compare scenarios#486

Merged
gdalle merged 5 commits intomainfrom
gd/dit_no_isequal
Sep 23, 2024
Merged

Remove use of custom isequal to compare scenarios#486
gdalle merged 5 commits intomainfrom
gd/dit_no_isequal

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Sep 23, 2024

DIT source

  • Implement == between Scenarios
  • Disallow passing custom isequal to check that scenarios have been preserved
  • Replace it with scenario_intact=true/false

DIT extensions and tests

@gdalle gdalle linked an issue Sep 23, 2024 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.86%. Comparing base (f262504) to head (4ee3f4b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...erentiationInterfaceTest/src/scenarios/scenario.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   97.83%   97.86%   +0.02%     
==========================================
  Files         106      107       +1     
  Lines        4305     4312       +7     
==========================================
+ Hits         4212     4220       +8     
+ Misses         93       92       -1     
Flag Coverage Δ
DI 98.31% <ø> (+<0.01%) ⬆️
DIT 96.95% <95.65%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review September 23, 2024 14:42
@gdalle gdalle merged commit 0a0a943 into main Sep 23, 2024
@gdalle gdalle deleted the gd/dit_no_isequal branch September 24, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No custom equality testing in DIT

2 participants