Skip to content

Pick correct batch size for hessian#574

Merged
gdalle merged 1 commit intomainfrom
gd/so_bs
Oct 12, 2024
Merged

Pick correct batch size for hessian#574
gdalle merged 1 commit intomainfrom
gd/so_bs

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Oct 12, 2024

Versions

  • Bump DI to v0.6.12

DI source

  • Implement pick_hessian_batchsize(backend, N) = pick_batchsize(outer(backend), N)
  • Use it in dense and sparse hessian. Before that, Hessians with SecondOrder would have had batch size 1 by default.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.52%. Comparing base (4e70d75) to head (9e5847b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #574   +/-   ##
=======================================
  Coverage   97.52%   97.52%           
=======================================
  Files         108      108           
  Lines        4968     4970    +2     
=======================================
+ Hits         4845     4847    +2     
  Misses        123      123           
Flag Coverage Δ
DI 98.68% <100.00%> (+<0.01%) ⬆️
DIT 95.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit fd7580c into main Oct 12, 2024
@gdalle gdalle deleted the gd/so_bs branch October 12, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants