fix: overloaded_input_type for one-element vector input#954
fix: overloaded_input_type for one-element vector input#954gdalle merged 2 commits intoJuliaDiff:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 133 133
Lines 7982 7983 +1
=======================================
+ Hits 7838 7839 +1
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @ErikQQY, thanks for the suggested bug fix!
I tried to fix all of that, would you mind giving it a second, closer look, comparing it with https://github.com/JuliaDiff/ForwardDiff.jl/blob/master/src/config.jl#L159? Thanks |
|
I think the current fix looks good now. The previous implementation mess up different cases😅 |
|
Can we get a new release with this patch? I need this fix for some new functionalities. |
|
I tried to register a new version but Registrator didn't notice |
overloaded_input_typedoesn't work for jacobian with one-element vector: