Skip to content

Fix Function Calls #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2020
Merged

Fix Function Calls #109

merged 2 commits into from
Jul 12, 2020

Conversation

@kanav99
Copy link
Contributor

@kanav99 kanav99 commented Jul 12, 2020

No description provided.

@kanav99 kanav99 mentioned this pull request Jul 12, 2020
Merged
@kanav99
Copy link
Contributor Author

kanav99 commented Jul 12, 2020

I think there are still some errors

@kanav99
Copy link
Contributor Author

kanav99 commented Jul 12, 2020

Issue is, mapreduce doesn't call the reducing function if there is only one element

julia> mapreduce(i->[1],hcat, [1])
1-element Array{Int64,1}:
 1

julia> mapreduce(i->[1],hcat, [1,2])
1×2 Array{Int64,2}:
 1  1

@ChrisRackauckas ChrisRackauckas merged commit 4d05916 into JuliaDiff:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kanav99 @ChrisRackauckas