Skip to content

Save allocations for bipartite graph with symmetric patterns#102

Merged
gdalle merged 1 commit intomainfrom
gd/symmetric_pattern
Sep 20, 2024
Merged

Save allocations for bipartite graph with symmetric patterns#102
gdalle merged 1 commit intomainfrom
gd/symmetric_pattern

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Sep 20, 2024

  • Add a symmetric_pattern kwarg to coloring, which can only be used for :nonsymmetric coloring problems. I didn't add this to GreedyColoringAlgorithm because it is not a property of the algorithm per se.
  • Pass this kwarg to bipartite_graph and use it to save one allocation for the transpose of the sparse matrix. Even if this kwarg is false, also save the allocation whenever A isa Union{Symmetric,Hermitian}
  • Add tests of column and row colorings on symmetric matrices.

@gdalle gdalle linked an issue Sep 20, 2024 that may be closed by this pull request
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d8f579d) to head (c018181).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          729       732    +3     
=========================================
+ Hits           729       732    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 3246a9b into main Sep 20, 2024
@gdalle gdalle deleted the gd/symmetric_pattern branch September 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option to specify that a Jacobian has a symmetrical structure

1 participant