Conversation
…lying sparsity pattern
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 13 13
Lines 1010 1162 +152
==========================================
+ Hits 1010 1162 +152 ☔ View full report in Codecov by Sentry. |
|
You also implemented Update: I checked the code and I need to read again the |
Yeah, basically these three new orders are variants of the same underlying paradigm, which is |
|
gdalle, what is |
|
No, it's a very different one. I just re-read the section of the ColPack paper and I think we can skip it?
|
| !!! warning | ||
| This function is not coded with efficiency in mind, it is designed for small-scale tests. | ||
| """ | ||
| function valid_dynamic_order( |
There was a problem hiding this comment.
@amontoison this function is the most important one to understand, because the tests rely on it. The actual implementation of the order is just an asymptotically faster way to do what is written below.
|
@amontoison friendly bump, do you want us to try and merge this one? |
|
Following our chat with @amontoison, I'm merging this with clear warnings that the new orders are experimental and need further tests. That way we can start experimenting. |
This PR implements three additional orders from the ColPack paper:
SmallestLast,IncidenceDegree,DynamicLargestFirst(new version of #18).AdjacencyGraphandBipartiteGraph.The big question is where to find small examples to check that we return the correct orders. This is especially tricky because ties are broken in an arbitrary manner.