Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 855 851 -4
=========================================
- Hits 855 851 -4 ☔ View full report in Codecov by Sentry. |
gdalle
requested changes
Sep 28, 2024
amontoison
force-pushed
the
am/star_decompression
branch
from
7af83fb to
3cefc33
Compare
Collaborator
Author
|
@gdalle It should be good now :) |
gdalle
approved these changes
Sep 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also want the optimized version of
decompress!for star coloring when the user specifiesuplo=:Fand not only whenuplois not specified.