Skip to content

Improve type stability in star set#140

Merged
gdalle merged 1 commit intomainfrom
gd/typestab
Oct 3, 2024
Merged

Improve type stability in star set#140
gdalle merged 1 commit intomainfrom
gd/typestab

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Oct 3, 2024

Make sure that there is no branch where symmetric_coefficient returns nothing.

This caused JET's type stability tests to fail on the pre-release version of Julia in JuliaDiff/DifferentiationInterface.jl#535

@gdalle gdalle marked this pull request as ready for review October 3, 2024 16:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1cb3884) to head (e068f56).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #140   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          871       870    -1     
=========================================
- Hits           871       870    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 0ceb174 into main Oct 3, 2024
@gdalle gdalle deleted the gd/typestab branch October 3, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant