Skip to content

Support ADTypes.NoColoringAlgorithm#142

Merged
gdalle merged 2 commits intomainfrom
gd/nocoloringalgorithm
Oct 4, 2024
Merged

Support ADTypes.NoColoringAlgorithm#142
gdalle merged 2 commits intomainfrom
gd/nocoloringalgorithm

Conversation

@gdalle
Copy link
Copy Markdown
Member

@gdalle gdalle commented Oct 4, 2024

Fix #141 by overloading coloring on ADTypes.NoColoringAlgorithm to return a (trivial) ColumnColoringResult or RowColoringResult. Doesn't work on symmetric at the moment but it probably shouldn't anyway.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0ceb174) to head (ac74b09).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #142   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        12    +1     
  Lines          870       878    +8     
=========================================
+ Hits           870       878    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle marked this pull request as ready for review October 4, 2024 09:31
@gdalle gdalle merged commit 8430561 into main Oct 4, 2024
@gdalle gdalle deleted the gd/nocoloringalgorithm branch October 4, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support NoColoringAlgorithm from ADTypes

1 participant